sync/internal_api/js_sync_manager_observer.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/js_sync_manager_observer.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/js_sync_encryption_handler_observer.h ('k') | sync/internal_api/public/attachments/attachment_downloader_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/js_sync_manager_observer.h

diff --git a/sync/internal_api/js_sync_manager_observer.h b/sync/internal_api/js_sync_manager_observer.h

index 1e694a8c8838b3206d4ec9165c6437ef2471bdb6..58df73deac8d121136c38ce99232dd236583924d 100644

--- a/sync/internal_api/js_sync_manager_observer.h

+++ b/sync/internal_api/js_sync_manager_observer.h

@@ -27,24 +27,22 @@ class JsEventHandler;

class SYNC_EXPORT_PRIVATE JsSyncManagerObserver : public SyncManager::Observer {

public:

JsSyncManagerObserver();

- virtual ~JsSyncManagerObserver();

+ ~JsSyncManagerObserver() override;

void SetJsEventHandler(const WeakHandle<JsEventHandler>& event_handler);

// SyncManager::Observer implementation.

- virtual void OnSyncCycleCompleted(

+ void OnSyncCycleCompleted(

const sessions::SyncSessionSnapshot& snapshot) override;

- virtual void OnConnectionStatusChange(ConnectionStatus status) override;

- virtual void OnInitializationComplete(

+ void OnConnectionStatusChange(ConnectionStatus status) override;

+ void OnInitializationComplete(

const WeakHandle<JsBackend>& js_backend,

const WeakHandle<DataTypeDebugInfoListener>& debug_info_listener,

bool success,

syncer::ModelTypeSet restored_types) override;

- virtual void OnActionableError(

- const SyncProtocolError& sync_protocol_error) override;

- virtual void OnProtocolEvent(const ProtocolEvent& event) override;

- virtual void OnMigrationRequested(

- syncer::ModelTypeSet types) override;

+ void OnActionableError(const SyncProtocolError& sync_protocol_error) override;

+ void OnProtocolEvent(const ProtocolEvent& event) override;

+ void OnMigrationRequested(syncer::ModelTypeSet types) override;

private:

void HandleJsEvent(const tracked_objects::Location& from_here,