sync/internal_api/public/test/test_internal_components_factory.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/test/test_internal_components_factory.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h ('k') | sync/internal_api/public/write_node.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/test/test_internal_components_factory.h

diff --git a/sync/internal_api/public/test/test_internal_components_factory.h b/sync/internal_api/public/test/test_internal_components_factory.h

index 9b763ebf5f3227763e010baff32088bd3502a8ae..c8f61488d3a9765da2858e1ecb4718d205c10a9a 100644

--- a/sync/internal_api/public/test/test_internal_components_factory.h

+++ b/sync/internal_api/public/test/test_internal_components_factory.h

@@ -14,14 +14,14 @@ class TestInternalComponentsFactory : public InternalComponentsFactory {

explicit TestInternalComponentsFactory(const Switches& switches,

StorageOption option,

StorageOption* storage_used);

- virtual ~TestInternalComponentsFactory();

+ ~TestInternalComponentsFactory() override;

- virtual scoped_ptr<SyncScheduler> BuildScheduler(

+ scoped_ptr<SyncScheduler> BuildScheduler(

const std::string& name,

sessions::SyncSessionContext* context,

syncer::CancelationSignal* cancelation_signal) override;

- virtual scoped_ptr<sessions::SyncSessionContext> BuildContext(

+ scoped_ptr<sessions::SyncSessionContext> BuildContext(

ServerConnectionManager* connection_manager,

syncable::Directory* directory,

ExtensionsActivity* monitor,

@@ -30,13 +30,12 @@ class TestInternalComponentsFactory : public InternalComponentsFactory {

ModelTypeRegistry* model_type_registry,

const std::string& invalidator_client_id) override;

- virtual scoped_ptr<syncable::DirectoryBackingStore>

- BuildDirectoryBackingStore(

+ scoped_ptr<syncable::DirectoryBackingStore> BuildDirectoryBackingStore(

StorageOption storage,

const std::string& dir_name,

const base::FilePath& backing_filepath) override;

- virtual Switches GetSwitches() const override;

+ Switches GetSwitches() const override;

private:

const Switches switches_;