Introduce Element::AttributeModificationParams

Introduce Element::AttributeModificationParams

AttributeModificationParams packs four parameters into one for
Element::attributeChanged, Element::parseAttribute, and Element::
logUpdateAttributeIfIsolatedWorldAndInDocument. It reduces stack operations and
improves performance of attribute modification.

BUG=677446
Review-Url: https://codereview.chromium.org/2623513005
Cr-Commit-Position: refs/heads/master@{#442541}
Committed: https://chromium.googlesource.com/chromium/src/+/cdb6d2b9b6f94fb4ed02c0b315ad56c5bc5b5b89

[tkent, 2017-01-10 05:47:17]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 05:47:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-01-10 05:57:48]

Description was changed from

==========
Introduce Element::AttributeModificationParams

AttributeModificationParams packs four parameters into one for
Element::attributeChanged and Element::parseAttribute. It reduces stack
operations and improves performance of attribute modification.

BUG=677446
==========

to

==========
Introduce Element::AttributeModificationParams

AttributeModificationParams packs four parameters into one for
Element::attributeChanged, Element::parseAttribute, and Element::
logUpdateAttributeIfIsolatedWorldAndInDocument. It reduces stack operations and
improves performance of attribute modification.

BUG=677446
==========

[tkent, 2017-01-10 07:22:41]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2017-01-10 07:22:42]

kochi-san, would you review this please?

This fixes a performance regression by
https://codereview.chromium.org/2586143004, which I landed last month.

[tkent, 2017-01-10 07:23:56]

On 2017/01/10 at 07:22:42, tkent wrote:
> This fixes a performance regression by
https://codereview.chromium.org/2586143004, which I landed last month.

On macOS, 730.6 runs/sec -> 749.5 runs/sec.

[kochi, 2017-01-10 07:56:20]

lgtm

[tkent, 2017-01-10 08:25:10]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2017-01-10 08:25:15]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-01-10 08:25:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 09:45:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484036715533240, "parent_rev":
"0e91f591193bd8616a44a2c307f58ca11255c62c", "commit_rev":
"cdb6d2b9b6f94fb4ed02c0b315ad56c5bc5b5b89"}

[commit-bot: I haz the power, 2017-01-10 09:45:53]

Description was changed from

==========
Introduce Element::AttributeModificationParams

AttributeModificationParams packs four parameters into one for
Element::attributeChanged, Element::parseAttribute, and Element::
logUpdateAttributeIfIsolatedWorldAndInDocument. It reduces stack operations and
improves performance of attribute modification.

BUG=677446
==========

to

==========
Introduce Element::AttributeModificationParams

AttributeModificationParams packs four parameters into one for
Element::attributeChanged, Element::parseAttribute, and Element::
logUpdateAttributeIfIsolatedWorldAndInDocument. It reduces stack operations and
improves performance of attribute modification.

BUG=677446

Review-Url: https://codereview.chromium.org/2623513005
Cr-Commit-Position: refs/heads/master@{#442541}
Committed:
https://chromium.googlesource.com/chromium/src/+/cdb6d2b9b6f94fb4ed02c0b315ad...
==========

[commit-bot: I haz the power, 2017-01-10 09:45:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cdb6d2b9b6f94fb4ed02c0b315ad...