Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
index c4a3b674f483bdfe8f6e7b8dc01a68f0a59e1077..ca04994e55a7fc4f223d8d7ac6da85e2e6ed7c81 100644
--- a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
+++ b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
@@ -445,9 +445,9 @@ void SVGSMILElement::parseBeginOrEnd(const String& parseString,
sortTimeList(timeList);
}
-void SVGSMILElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
+void SVGSMILElement::parseAttribute(const AttributeModificationParams& params) {
+ const QualifiedName& name = params.name;
+ const AtomicString& value = params.newValue;
if (name == SVGNames::beginAttr) {
if (!m_conditions.isEmpty()) {
clearConditions();
@@ -477,7 +477,7 @@ void SVGSMILElement::parseAttribute(const QualifiedName& name,
EventTypeNames::repeatEvent,
createAttributeEventListener(this, name, value, eventParameterName()));
} else {
- SVGElement::parseAttribute(name, oldValue, value);
+ SVGElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698