Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp b/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
index fc409ca732ded2334b3d4b09f91e144db31f8001..bf6ddbec164cc586700c3cc86ac3ad4dd66ff82f 100644
--- a/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
@@ -62,17 +62,17 @@ HTMLLinkElement* HTMLLinkElement::create(Document& document,
HTMLLinkElement::~HTMLLinkElement() {}
-void HTMLLinkElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
+void HTMLLinkElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ const QualifiedName& name = params.name;
+ const AtomicString& value = params.newValue;
if (name == relAttr) {
m_relAttribute = LinkRelAttribute(value);
m_relList->setRelValues(value);
process();
} else if (name == hrefAttr) {
// Log href attribute before logging resource fetching in process().
- logUpdateAttributeIfIsolatedWorldAndInDocument("link", hrefAttr, oldValue,
- value);
+ logUpdateAttributeIfIsolatedWorldAndInDocument("link", params);
process();
} else if (name == typeAttr) {
m_type = value;
@@ -102,7 +102,7 @@ void HTMLLinkElement::parseAttribute(const QualifiedName& name,
link->setSheetTitle(value);
}
- HTMLElement::parseAttribute(name, oldValue, value);
+ HTMLElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLLinkElement.h ('k') | third_party/WebKit/Source/core/html/HTMLMapElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698