Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: third_party/WebKit/Source/core/html/HTMLScriptElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp b/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
index 9cddf84b511512b5ff9153e57de6a04590c8a1a6..4bbe28de2e88c8453172bee74824b95aabb3af93 100644
--- a/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
@@ -79,17 +79,15 @@ void HTMLScriptElement::didMoveToNewDocument(Document& oldDocument) {
HTMLElement::didMoveToNewDocument(oldDocument);
}
-void HTMLScriptElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
- if (name == srcAttr) {
- m_loader->handleSourceAttribute(value);
- logUpdateAttributeIfIsolatedWorldAndInDocument("script", srcAttr, oldValue,
- value);
- } else if (name == asyncAttr) {
+void HTMLScriptElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ if (params.name == srcAttr) {
+ m_loader->handleSourceAttribute(params.newValue);
+ logUpdateAttributeIfIsolatedWorldAndInDocument("script", params);
+ } else if (params.name == asyncAttr) {
m_loader->handleAsyncAttribute();
} else {
- HTMLElement::parseAttribute(name, oldValue, value);
+ HTMLElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLScriptElement.h ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698