Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp b/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
index e0c6a6825f886c403d97a5ad5d3df15eca4cc21a..7970884c4e3e3cdb3ff953162a6fe067ac3d227d 100644
--- a/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
@@ -118,12 +118,11 @@ Element* HTMLDetailsElement::findMainSummary() const {
return toElement(content->firstChild());
}
-void HTMLDetailsElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
- if (name == openAttr) {
+void HTMLDetailsElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ if (params.name == openAttr) {
bool oldValue = m_isOpen;
- m_isOpen = !value.isNull();
+ m_isOpen = !params.newValue.isNull();
if (m_isOpen == oldValue)
return;
@@ -154,7 +153,7 @@ void HTMLDetailsElement::parseAttribute(const QualifiedName& name,
return;
}
- HTMLElement::parseAttribute(name, oldValue, value);
+ HTMLElement::parseAttribute(params);
}
void HTMLDetailsElement::toggleOpen() {
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLDetailsElement.h ('k') | third_party/WebKit/Source/core/html/HTMLElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698