Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: third_party/WebKit/Source/core/html/HTMLAreaElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLAreaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp
index 595484ffdeba11103014ae68852cd1159b0d6e4b..c0a9a85ca6c8eb353b9cc8f1557c1c0217736d8d 100644
--- a/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp
@@ -57,10 +57,10 @@ HTMLAreaElement::~HTMLAreaElement() {}
DEFINE_NODE_FACTORY(HTMLAreaElement)
-void HTMLAreaElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
- if (name == shapeAttr) {
+void HTMLAreaElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ const AtomicString& value = params.newValue;
+ if (params.name == shapeAttr) {
if (equalIgnoringASCIICase(value, "default")) {
m_shape = Default;
} else if (equalIgnoringASCIICase(value, "circle") ||
@@ -75,13 +75,13 @@ void HTMLAreaElement::parseAttribute(const QualifiedName& name,
m_shape = Rect;
}
invalidateCachedPath();
- } else if (name == coordsAttr) {
+ } else if (params.name == coordsAttr) {
m_coords = parseHTMLListOfFloatingPointNumbers(value.getString());
invalidateCachedPath();
- } else if (name == altAttr || name == accesskeyAttr) {
+ } else if (params.name == altAttr || params.name == accesskeyAttr) {
// Do nothing.
} else {
- HTMLAnchorElement::parseAttribute(name, oldValue, value);
+ HTMLAnchorElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAreaElement.h ('k') | third_party/WebKit/Source/core/html/HTMLBaseElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698