Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
index 150abce01a41f02c68df76908978335e0404230b..5f44a25840433092f131e9be0c6253a3b080c8b9 100644
--- a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
@@ -97,9 +97,10 @@ void HTMLIFrameElement::collectStyleForPresentationAttribute(
}
}
-void HTMLIFrameElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
+void HTMLIFrameElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ const QualifiedName& name = params.name;
+ const AtomicString& value = params.newValue;
if (name == nameAttr) {
if (isInDocumentTree() && document().isHTMLDocument()) {
HTMLDocument& document = toHTMLDocument(this->document());
@@ -144,9 +145,8 @@ void HTMLIFrameElement::parseAttribute(const QualifiedName& name,
frameOwnerPropertiesChanged();
} else {
if (name == srcAttr)
- logUpdateAttributeIfIsolatedWorldAndInDocument("iframe", srcAttr,
- oldValue, value);
- HTMLFrameElementBase::parseAttribute(name, oldValue, value);
+ logUpdateAttributeIfIsolatedWorldAndInDocument("iframe", params);
+ HTMLFrameElementBase::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLIFrameElement.h ('k') | third_party/WebKit/Source/core/html/HTMLImageElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698