Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
index 12897b97dfd8861593688b900614964d4ce32ae3..2e2e50ab97d12e54bf90b8f020a09da74b5b6735 100644
--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
@@ -114,10 +114,9 @@ bool HTMLVideoElement::isPresentationAttribute(
return HTMLMediaElement::isPresentationAttribute(name);
}
-void HTMLVideoElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
- if (name == posterAttr) {
+void HTMLVideoElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ if (params.name == posterAttr) {
// In case the poster attribute is set after playback, don't update the
// display state, post playback the correct state will be picked up.
if (getDisplayMode() < Video || !hasAvailableVideoFrame()) {
@@ -138,7 +137,7 @@ void HTMLVideoElement::parseAttribute(const QualifiedName& name,
if (webMediaPlayer())
webMediaPlayer()->setPoster(posterImageURL());
} else {
- HTMLMediaElement::parseAttribute(name, oldValue, value);
+ HTMLMediaElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLVideoElement.h ('k') | third_party/WebKit/Source/core/html/TextControlElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698