Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
index 8f801256185cd14fe8c6398aae968acc2eede131..a3d83420b2bb02e3b315cc7078b5f17e818978f7 100644
--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
@@ -147,9 +147,10 @@ void HTMLTextAreaElement::collectStyleForPresentationAttribute(
}
}
-void HTMLTextAreaElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
+void HTMLTextAreaElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ const QualifiedName& name = params.name;
+ const AtomicString& value = params.newValue;
if (name == rowsAttr) {
unsigned rows = 0;
if (value.isEmpty() || !parseHTMLNonNegativeInteger(value, rows) ||
@@ -200,7 +201,7 @@ void HTMLTextAreaElement::parseAttribute(const QualifiedName& name,
UseCounter::count(document(), UseCounter::TextAreaMinLength);
setNeedsValidityCheck();
} else {
- TextControlElement::parseAttribute(name, oldValue, value);
+ TextControlElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextAreaElement.h ('k') | third_party/WebKit/Source/core/html/HTMLTrackElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698