Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: third_party/WebKit/Source/core/html/HTMLOListElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLOListElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLOListElement.cpp b/third_party/WebKit/Source/core/html/HTMLOListElement.cpp
index 49dd5b86c2df8875aa842ce445a0fbbf63169e41..5a71b26b1a54cbfe6b2c007874bbece97af9c675 100644
--- a/third_party/WebKit/Source/core/html/HTMLOListElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLOListElement.cpp
@@ -74,26 +74,25 @@ void HTMLOListElement::collectStyleForPresentationAttribute(
}
}
-void HTMLOListElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
- if (name == startAttr) {
+void HTMLOListElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ if (params.name == startAttr) {
int oldStart = start();
int parsedStart = 0;
- bool canParse = parseHTMLInteger(value, parsedStart);
+ bool canParse = parseHTMLInteger(params.newValue, parsedStart);
m_hasExplicitStart = canParse;
m_start = canParse ? parsedStart : 0xBADBEEF;
if (oldStart == start())
return;
updateItemValues();
- } else if (name == reversedAttr) {
- bool reversed = !value.isNull();
+ } else if (params.name == reversedAttr) {
+ bool reversed = !params.newValue.isNull();
if (reversed == m_isReversed)
return;
m_isReversed = reversed;
updateItemValues();
} else {
- HTMLElement::parseAttribute(name, oldValue, value);
+ HTMLElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOListElement.h ('k') | third_party/WebKit/Source/core/html/HTMLObjectElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698