Introduce Element::AttributeModificationParams

third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp

 /*
  * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 134 matching lines @@
     parsed = parseKeySplinesInternal<LChar>(string, result);
   else
     parsed = parseKeySplinesInternal<UChar>(string, result);
   if (!parsed) {
     result.clear();
     return false;
   }
   return true;
 }
 
-void SVGAnimationElement::parseAttribute(const QualifiedName& name,
-                                         const AtomicString& oldValue,
-                                         const AtomicString& value) {
+void SVGAnimationElement::parseAttribute(
+    const AttributeModificationParams& params) {
+  const QualifiedName& name = params.name;
   if (name == SVGNames::valuesAttr) {
-    if (!parseValues(value, m_values)) {
-      reportAttributeParsingError(SVGParseStatus::ParsingFailed, name, value);
+    if (!parseValues(params.newValue, m_values)) {
+      reportAttributeParsingError(SVGParseStatus::ParsingFailed, name,
+                                  params.newValue);
       return;
     }
     updateAnimationMode();
     return;
   }
 
   if (name == SVGNames::keyTimesAttr) {
-    if (!parseKeyTimes(value, m_keyTimes, true))
-      reportAttributeParsingError(SVGParseStatus::ParsingFailed, name, value);
+    if (!parseKeyTimes(params.newValue, m_keyTimes, true)) {
+      reportAttributeParsingError(SVGParseStatus::ParsingFailed, name,
+                                  params.newValue);
+    }
     return;
   }
 
   if (name == SVGNames::keyPointsAttr) {
     if (isSVGAnimateMotionElement(*this)) {
       // This is specified to be an animateMotion attribute only but it is
       // simpler to put it here where the other timing calculatations are.
-      if (!parseKeyTimes(value, m_keyPoints, false))
-        reportAttributeParsingError(SVGParseStatus::ParsingFailed, name, value);
+      if (!parseKeyTimes(params.newValue, m_keyPoints, false)) {
+        reportAttributeParsingError(SVGParseStatus::ParsingFailed, name,
+                                    params.newValue);
+      }
     }
     return;
   }
 
   if (name == SVGNames::keySplinesAttr) {
-    if (!parseKeySplines(value, m_keySplines))
-      reportAttributeParsingError(SVGParseStatus::ParsingFailed, name, value);
+    if (!parseKeySplines(params.newValue, m_keySplines)) {
+      reportAttributeParsingError(SVGParseStatus::ParsingFailed, name,
+                                  params.newValue);
+    }
     return;
   }
 
   if (name == SVGNames::calcModeAttr) {
-    setCalcMode(value);
+    setCalcMode(params.newValue);
     return;
   }
 
   if (name == SVGNames::fromAttr || name == SVGNames::toAttr ||
       name == SVGNames::byAttr) {
     updateAnimationMode();
     return;
   }
 
-  SVGSMILElement::parseAttribute(name, oldValue, value);
+  SVGSMILElement::parseAttribute(params);
 }
 
 void SVGAnimationElement::svgAttributeChanged(const QualifiedName& attrName) {
   if (attrName == SVGNames::valuesAttr || attrName == SVGNames::byAttr ||
       attrName == SVGNames::fromAttr || attrName == SVGNames::toAttr ||
       attrName == SVGNames::calcModeAttr ||
       attrName == SVGNames::keySplinesAttr ||
       attrName == SVGNames::keyPointsAttr ||
       attrName == SVGNames::keyTimesAttr) {
     animationAttributeChanged();
@@ skipping 403 matching lines @@
         calculatePercentForSpline(percent, calculateKeyTimesIndex(percent));
   else if (animationMode == FromToAnimation || animationMode == ToAnimation)
     effectivePercent = calculatePercentForFromTo(percent);
   else
     effectivePercent = percent;
 
   calculateAnimatedValue(effectivePercent, repeatCount, resultElement);
 }
 
 }  // namespace blink