Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
index d298d7a80ea854044c57e5002eff3f6f50b0e510..42ce6cf622668590db098c89ec3fd8a3b9d03fd9 100644
--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
@@ -199,18 +199,17 @@ void HTMLSlotElement::detachLayoutTree(const AttachContext& context) {
HTMLElement::detachLayoutTree(context);
}
-void HTMLSlotElement::attributeChanged(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& newValue,
- AttributeModificationReason reason) {
- if (name == nameAttr) {
+void HTMLSlotElement::attributeChanged(
+ const AttributeModificationParams& params) {
+ if (params.name == nameAttr) {
if (ShadowRoot* root = containingShadowRoot()) {
- if (root->isV1() && oldValue != newValue)
- root->ensureSlotAssignment().slotRenamed(normalizeSlotName(oldValue),
- *this);
+ if (root->isV1() && params.oldValue != params.newValue) {
+ root->ensureSlotAssignment().slotRenamed(
+ normalizeSlotName(params.oldValue), *this);
+ }
}
}
- HTMLElement::attributeChanged(name, oldValue, newValue, reason);
+ HTMLElement::attributeChanged(params);
}
static bool wasInShadowTreeBeforeInserted(HTMLSlotElement& slot,
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSlotElement.h ('k') | third_party/WebKit/Source/core/html/HTMLSourceElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698