Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: third_party/WebKit/Source/core/svg/SVGScriptElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp b/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
index a6a3a319650152a6693ff50ea8e43ea2ca875998..25dbc97fcfc8fa03ff438bec4c32a86c857b442e 100644
--- a/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
@@ -42,15 +42,16 @@ SVGScriptElement* SVGScriptElement::create(Document& document,
return new SVGScriptElement(document, insertedByParser, false);
}
-void SVGScriptElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
- if (name == HTMLNames::onerrorAttr)
+void SVGScriptElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ if (params.name == HTMLNames::onerrorAttr) {
setAttributeEventListener(
EventTypeNames::error,
- createAttributeEventListener(this, name, value, eventParameterName()));
- else
- SVGElement::parseAttribute(name, oldValue, value);
+ createAttributeEventListener(this, params.name, params.newValue,
+ eventParameterName()));
+ } else {
+ SVGElement::parseAttribute(params);
+ }
}
void SVGScriptElement::svgAttributeChanged(const QualifiedName& attrName) {
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGScriptElement.h ('k') | third_party/WebKit/Source/core/svg/SVGStyleElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698