Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
index f52ece698b952bc35de1820910055a0d579b7cd5..628607c873fc5bf564e8560811c1fe0bf64d735f 100644
--- a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
@@ -93,13 +93,13 @@ void HTMLObjectElement::collectStyleForPresentationAttribute(
HTMLPlugInElement::collectStyleForPresentationAttribute(name, value, style);
}
-void HTMLObjectElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
+void HTMLObjectElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ const QualifiedName& name = params.name;
if (name == formAttr) {
formAttributeChanged();
} else if (name == typeAttr) {
- m_serviceType = value.lower();
+ m_serviceType = params.newValue.lower();
size_t pos = m_serviceType.find(";");
if (pos != kNotFound)
m_serviceType = m_serviceType.left(pos);
@@ -110,7 +110,7 @@ void HTMLObjectElement::parseAttribute(const QualifiedName& name,
if (!layoutObject())
requestPluginCreationWithoutLayoutObjectIfPossible();
} else if (name == dataAttr) {
- m_url = stripLeadingAndTrailingHTMLSpaces(value);
+ m_url = stripLeadingAndTrailingHTMLSpaces(params.newValue);
if (layoutObject() && isImageType()) {
setNeedsWidgetUpdate(true);
if (!m_imageLoader)
@@ -120,10 +120,10 @@ void HTMLObjectElement::parseAttribute(const QualifiedName& name,
reloadPluginOnAttributeChange(name);
}
} else if (name == classidAttr) {
- m_classId = value;
+ m_classId = params.newValue;
reloadPluginOnAttributeChange(name);
} else {
- HTMLPlugInElement::parseAttribute(name, oldValue, value);
+ HTMLPlugInElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLObjectElement.h ('k') | third_party/WebKit/Source/core/html/HTMLOptGroupElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698