Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
index 05e28a7fc73ba85483de25684ad64ddd886be869..783f9c4301f10f37660fe7c80f60c71f3432b3e1 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
@@ -130,9 +130,10 @@ void HTMLFrameElementBase::frameOwnerPropertiesChanged() {
document().frame()->loader().client()->didChangeFrameOwnerProperties(this);
}
-void HTMLFrameElementBase::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
+void HTMLFrameElementBase::parseAttribute(
+ const AttributeModificationParams& params) {
+ const QualifiedName& name = params.name;
+ const AtomicString& value = params.newValue;
if (name == srcdocAttr) {
if (!value.isNull()) {
setLocation(srcdocURL().getString());
@@ -146,7 +147,7 @@ void HTMLFrameElementBase::parseAttribute(const QualifiedName& name,
} else if (name == idAttr) {
// Important to call through to base for the id attribute so the hasID bit
// gets set.
- HTMLFrameOwnerElement::parseAttribute(name, oldValue, value);
+ HTMLFrameOwnerElement::parseAttribute(params);
m_frameName = value;
} else if (name == nameAttr) {
m_frameName = value;
@@ -167,7 +168,7 @@ void HTMLFrameElementBase::parseAttribute(const QualifiedName& name,
EventTypeNames::beforeunload,
createAttributeEventListener(this, name, value, eventParameterName()));
} else {
- HTMLFrameOwnerElement::parseAttribute(name, oldValue, value);
+ HTMLFrameOwnerElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameElementBase.h ('k') | third_party/WebKit/Source/core/html/HTMLFrameSetElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698