Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
index 1432874ccd9f34fd537d80d11edd05773d067a2f..4efa77cdc91b26d821bf4adc3a72403840b8d62c 100644
--- a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
@@ -155,9 +155,9 @@ bool SVGSVGElement::zoomAndPanEnabled() const {
return zoomAndPan == SVGZoomAndPanMagnify;
}
-void SVGSVGElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
+void SVGSVGElement::parseAttribute(const AttributeModificationParams& params) {
+ const QualifiedName& name = params.name;
+ const AtomicString& value = params.newValue;
if (!nearestViewportElement()) {
bool setListener = true;
@@ -206,7 +206,7 @@ void SVGSVGElement::parseAttribute(const QualifiedName& name,
property->setDefaultValueAsString("100%");
reportAttributeParsingError(parseError, name, value);
} else {
- SVGElement::parseAttribute(name, oldValue, value);
+ SVGElement::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGSVGElement.h ('k') | third_party/WebKit/Source/core/svg/SVGScriptElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698