Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
index dc398ebdb80e06cb5b791829b86f9e4843c1e1d3..8d6bff057d19f81b6c024276e88136fda3b1d8c5 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
@@ -62,18 +62,17 @@ void HTMLFrameElement::attachLayoutTree(const AttachContext& context) {
}
}
-void HTMLFrameElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
- if (name == frameborderAttr) {
- m_frameBorder = value.toInt();
- m_frameBorderSet = !value.isNull();
+void HTMLFrameElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ if (params.name == frameborderAttr) {
+ m_frameBorder = params.newValue.toInt();
+ m_frameBorderSet = !params.newValue.isNull();
// FIXME: If we are already attached, this has no effect.
- } else if (name == noresizeAttr) {
+ } else if (params.name == noresizeAttr) {
if (layoutObject())
layoutObject()->updateFromElement();
} else {
- HTMLFrameElementBase::parseAttribute(name, oldValue, value);
+ HTMLFrameElementBase::parseAttribute(params);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameElement.h ('k') | third_party/WebKit/Source/core/html/HTMLFrameElementBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698