Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSourceElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp b/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
index ef1628994099f582c704dcb0c1123ae827bedae4..1bbece04062ec88c930d3e2f646809fa5b4be87d 100644
--- a/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
@@ -164,12 +164,12 @@ bool HTMLSourceElement::isURLAttribute(const Attribute& attribute) const {
return attribute.name() == srcAttr || HTMLElement::isURLAttribute(attribute);
}
-void HTMLSourceElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
- HTMLElement::parseAttribute(name, oldValue, value);
+void HTMLSourceElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ HTMLElement::parseAttribute(params);
+ const QualifiedName& name = params.name;
if (name == mediaAttr)
- createMediaQueryList(value);
+ createMediaQueryList(params.newValue);
if (name == srcsetAttr || name == sizesAttr || name == mediaAttr ||
name == typeAttr) {
Element* parent = parentElement();
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSourceElement.h ('k') | third_party/WebKit/Source/core/html/HTMLStyleElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698