Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp
index 138a063a09b3349582e0511cd9327498d85f5df1..5b83ba0cd2d796a19a1be9b6e6812e294feabc73 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp
@@ -71,17 +71,16 @@ bool SVGAnimateMotionElement::hasValidTarget() {
targetCanHaveMotionTransform(*targetElement());
}
-void SVGAnimateMotionElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
- if (name == SVGNames::pathAttr) {
+void SVGAnimateMotionElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ if (params.name == SVGNames::pathAttr) {
m_path = Path();
- buildPathFromString(value, m_path);
+ buildPathFromString(params.newValue, m_path);
updateAnimationPath();
return;
}
- SVGAnimationElement::parseAttribute(name, oldValue, value);
+ SVGAnimationElement::parseAttribute(params);
}
SVGAnimateMotionElement::RotateMode SVGAnimateMotionElement::getRotateMode()

Powered by Google App Engine
This is Rietveld 408576698