Introduce Element::AttributeModificationParams

third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

 /*
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights
  * reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
@@ skipping 276 matching lines @@
     const QualifiedName& name) const {
   if (name == alignAttr) {
     // Don't map 'align' attribute. This matches what Firefox, Opera and IE do.
     // See http://bugs.webkit.org/show_bug.cgi?id=12072
     return false;
   }
 
   return HTMLFormControlElementWithState::isPresentationAttribute(name);
 }
 
-void HTMLSelectElement::parseAttribute(const QualifiedName& name,
-                                       const AtomicString& oldValue,
-                                       const AtomicString& value) {
-  if (name == sizeAttr) {
+void HTMLSelectElement::parseAttribute(
+    const AttributeModificationParams& params) {
+  if (params.name == sizeAttr) {
     unsigned oldSize = m_size;
     // Set the attribute value to a number.
     // This is important since the style rules for this attribute can
     // determine the appearance property.
-    unsigned size = value.getString().toUInt();
+    unsigned size = params.newValue.getString().toUInt();
     AtomicString attrSize = AtomicString::number(size);
-    if (attrSize != value) {
+    if (attrSize != params.newValue) {
       // FIXME: This is horribly factored.
       if (Attribute* sizeAttribute =
               ensureUniqueElementData().attributes().find(sizeAttr))
         sizeAttribute->setValue(attrSize);
     }
     m_size = size;
     setNeedsValidityCheck();
     if (m_size != oldSize) {
       if (inActiveDocument())
         lazyReattachIfAttached();
       resetToDefaultSelection();
       if (!usesMenuList())
         saveListboxActiveSelection();
     }
-  } else if (name == multipleAttr) {
-    parseMultipleAttribute(value);
-  } else if (name == accesskeyAttr) {
+  } else if (params.name == multipleAttr) {
+    parseMultipleAttribute(params.newValue);
+  } else if (params.name == accesskeyAttr) {
     // FIXME: ignore for the moment.
     //
   } else {
-    HTMLFormControlElementWithState::parseAttribute(name, oldValue, value);
+    HTMLFormControlElementWithState::parseAttribute(params);
   }
 }
 
 bool HTMLSelectElement::shouldShowFocusRingOnMouseFocus() const {
   return true;
 }
 
 bool HTMLSelectElement::canSelectAll() const {
   return !usesMenuList();
 }
@@ skipping 1706 matching lines @@
   m_popupUpdater = nullptr;
 }
 
 void HTMLSelectElement::didMutateSubtree() {
   DCHECK(popupIsVisible());
   DCHECK(m_popup);
   m_popup->updateFromElement(PopupMenu::ByDOMChange);
 }
 
 }  // namespace blink