Introduce Element::AttributeModificationParams

third_party/WebKit/Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
@@ skipping 467 matching lines @@
   }
 
   m_needsToUpdateViewValue = true;
   m_inputTypeView->updateView();
 
   if (didRespectHeightAndWidth !=
       m_inputType->shouldRespectHeightAndWidthAttributes()) {
     DCHECK(elementData());
     AttributeCollection attributes = attributesWithoutUpdate();
     if (const Attribute* height = attributes.find(heightAttr)) {
-      TextControlElement::attributeChanged(
+      TextControlElement::attributeChanged(AttributeModificationParams(
           heightAttr, height->value(), height->value(),
-          AttributeModificationReason::kDirectly);
+          AttributeModificationReason::kDirectly));
     }
     if (const Attribute* width = attributes.find(widthAttr)) {
       TextControlElement::attributeChanged(
-          widthAttr, width->value(), width->value(),
-          AttributeModificationReason::kDirectly);
+          AttributeModificationParams(widthAttr, width->value(), width->value(),
+                                      AttributeModificationReason::kDirectly));
     }
     if (const Attribute* align = attributes.find(alignAttr)) {
       TextControlElement::attributeChanged(
-          alignAttr, align->value(), align->value(),
-          AttributeModificationReason::kDirectly);
+          AttributeModificationParams(alignAttr, align->value(), align->value(),
+                                      AttributeModificationReason::kDirectly));
     }
   }
 
   if (document().focusedElement() == this)
     document().updateFocusAppearanceSoon(SelectionBehaviorOnFocus::Restore);
 
   setTextAsOfLastFormControlChangeEvent(value());
   setChangedSinceLastFormControlChangeEvent(false);
 
   addToRadioButtonGroup();
@@ skipping 179 matching lines @@
       addHTMLLengthToStyle(style, CSSPropertyHeight, value);
   } else if (name == borderAttr &&
              type() == InputTypeNames::image) {  // FIXME: Remove type check.
     applyBorderAttributeToStyle(value, style);
   } else {
     TextControlElement::collectStyleForPresentationAttribute(name, value,
                                                              style);
   }
 }
 
-void HTMLInputElement::parseAttribute(const QualifiedName& name,
-                                      const AtomicString& oldValue,
-                                      const AtomicString& value) {
+void HTMLInputElement::parseAttribute(
+    const AttributeModificationParams& params) {
   DCHECK(m_inputType);
   DCHECK(m_inputTypeView);
+  const QualifiedName& name = params.name;
+  const AtomicString& value = params.newValue;
 
   if (name == nameAttr) {
     removeFromRadioButtonGroup();
     m_name = value;
     addToRadioButtonGroup();
-    TextControlElement::parseAttribute(name, oldValue, value);
+    TextControlElement::parseAttribute(params);
   } else if (name == autocompleteAttr) {
     if (equalIgnoringCase(value, "off")) {
       m_autocomplete = Off;
     } else {
       if (value.isEmpty())
         m_autocomplete = Uninitialized;
       else
         m_autocomplete = On;
     }
   } else if (name == typeAttr) {
@@ skipping 70 matching lines @@
     m_inputTypeView->multipleAttributeChanged();
     setNeedsValidityCheck();
   } else if (name == stepAttr) {
     m_inputTypeView->stepAttributeChanged();
     setNeedsValidityCheck();
     UseCounter::count(document(), UseCounter::StepAttribute);
   } else if (name == patternAttr) {
     setNeedsValidityCheck();
     UseCounter::count(document(), UseCounter::PatternAttribute);
   } else if (name == readonlyAttr) {
-    TextControlElement::parseAttribute(name, oldValue, value);
+    TextControlElement::parseAttribute(params);
     m_inputTypeView->readonlyAttributeChanged();
   } else if (name == listAttr) {
     m_hasNonEmptyList = !value.isEmpty();
     if (m_hasNonEmptyList) {
       resetListAttributeTargetObserver();
       listAttributeTargetChanged();
     }
     UseCounter::count(document(), UseCounter::ListAttribute);
   } else if (name == webkitdirectoryAttr) {
-    TextControlElement::parseAttribute(name, oldValue, value);
+    TextControlElement::parseAttribute(params);
     UseCounter::count(document(), UseCounter::PrefixedDirectoryAttribute);
   } else {
     if (name == formactionAttr)
-      logUpdateAttributeIfIsolatedWorldAndInDocument("input", formactionAttr,
-                                                     oldValue, value);
-    TextControlElement::parseAttribute(name, oldValue, value);
+      logUpdateAttributeIfIsolatedWorldAndInDocument("input", params);
+    TextControlElement::parseAttribute(params);
   }
   m_inputTypeView->attributeChanged();
 }
 
 void HTMLInputElement::parserDidSetAttributes() {
   DCHECK(m_parsingInProgress);
   initializeTypeInParsing();
 }
 
 void HTMLInputElement::finishParsingChildren() {
@@ skipping 1060 matching lines @@
 
 bool HTMLInputElement::hasFallbackContent() const {
   return m_inputTypeView->hasFallbackContent();
 }
 
 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths) {
   return m_inputType->setFilesFromPaths(paths);
 }
 
 }  // namespace blink