Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Issue 2623513005: Introduce Element::AttributeModificationParams (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLTableElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
index 6ee41ac470281e5bfc61bc727aa91ed9e44f4ceb..6d507ba3f0712a285d36db17bfa20c961dd39415 100644
--- a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
@@ -386,17 +386,17 @@ bool HTMLTableElement::isPresentationAttribute(
return HTMLElement::isPresentationAttribute(name);
}
-void HTMLTableElement::parseAttribute(const QualifiedName& name,
- const AtomicString& oldValue,
- const AtomicString& value) {
+void HTMLTableElement::parseAttribute(
+ const AttributeModificationParams& params) {
+ const QualifiedName& name = params.name;
CellBorders bordersBefore = getCellBorders();
unsigned short oldPadding = m_padding;
if (name == borderAttr) {
// FIXME: This attribute is a mess.
- m_borderAttr = parseBorderWidthAttribute(value);
+ m_borderAttr = parseBorderWidthAttribute(params.newValue);
} else if (name == bordercolorAttr) {
- m_borderColorAttr = !value.isEmpty();
+ m_borderColorAttr = !params.newValue.isEmpty();
} else if (name == frameAttr) {
// FIXME: This attribute is a mess.
bool borderTop;
@@ -404,28 +404,28 @@ void HTMLTableElement::parseAttribute(const QualifiedName& name,
bool borderBottom;
bool borderLeft;
m_frameAttr = getBordersFromFrameAttributeValue(
- value, borderTop, borderRight, borderBottom, borderLeft);
+ params.newValue, borderTop, borderRight, borderBottom, borderLeft);
} else if (name == rulesAttr) {
m_rulesAttr = UnsetRules;
- if (equalIgnoringCase(value, "none"))
+ if (equalIgnoringCase(params.newValue, "none"))
m_rulesAttr = NoneRules;
- else if (equalIgnoringCase(value, "groups"))
+ else if (equalIgnoringCase(params.newValue, "groups"))
m_rulesAttr = GroupsRules;
- else if (equalIgnoringCase(value, "rows"))
+ else if (equalIgnoringCase(params.newValue, "rows"))
m_rulesAttr = RowsRules;
- else if (equalIgnoringCase(value, "cols"))
+ else if (equalIgnoringCase(params.newValue, "cols"))
m_rulesAttr = ColsRules;
- else if (equalIgnoringCase(value, "all"))
+ else if (equalIgnoringCase(params.newValue, "all"))
m_rulesAttr = AllRules;
- } else if (name == cellpaddingAttr) {
- if (!value.isEmpty())
- m_padding = std::max(0, value.toInt());
+ } else if (params.name == cellpaddingAttr) {
+ if (!params.newValue.isEmpty())
+ m_padding = std::max(0, params.newValue.toInt());
else
m_padding = 1;
- } else if (name == colsAttr) {
+ } else if (params.name == colsAttr) {
// ###
} else {
- HTMLElement::parseAttribute(name, oldValue, value);
+ HTMLElement::parseAttribute(params);
}
if (bordersBefore != getCellBorders() || oldPadding != m_padding) {
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTableElement.h ('k') | third_party/WebKit/Source/core/html/HTMLTextAreaElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698