Change ScopedVector to vector<unique_ptr> in the password's UI code.

Change ScopedVector to vector<unique_ptr> in the password's UI code.

In addition the code performs small related refactoring. No functional changes should happen.

BUG=555132
Committed: https://crrev.com/ca5afd3b53530d0422dc6add6a4227a2233e45f4
Cr-Commit-Position: refs/heads/master@{#413422}

[vasilii, 2016-08-18 15:27:14]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 15:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 15:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 15:39:35]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[vasilii, 2016-08-18 18:13:32]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 18:13:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2016-08-18 18:14:32]

Description was changed from

==========
Change ScopedVector to vector<unique_ptr> in the password's UI code.

BUG=555132
==========

to

==========
Change ScopedVector to vector<unique_ptr> in the password's UI code.

In addition the code performs small related refactoring. No functional changes
should happen.

BUG=555132
==========

[vasilii, 2016-08-18 18:14:32]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-08-18 18:15:15]

Hi Vaclav,

please review the CL.

[vabr (Chromium), 2016-08-18 18:39:19]

LGTM, just nits.
Thanks!
Vaclav

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
(right):

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm:75:
forms.push_back(base::WrapUnique(new autofill::PasswordForm(form)));
nit: Please use base::MakeUnique<autofill::PasswordForm>(form) instead.

See
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSa...
for reasons.

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/passw...
File chrome/browser/ui/passwords/manage_passwords_state.cc (right):

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/passw...
chrome/browser/ui/passwords/manage_passwords_state.cc:27: base::WrapUnique(new
autofill::PasswordForm(*form_pair.second)));
nit: base::MakeUnique again, or the emplace_back you did above.

Also on other places in this file.

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/passwords/manage_password_items_view.cc (right):

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/passwords/manage_password_items_view.cc:276:
password_forms_rows_.push_back(base::WrapUnique(
Also here: what about MakeUnique or emplace_back?

(And below.)

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/views...
File
chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
(right):

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc:300:
local_credentials.push_back(
And in this file: please consider MakeUnique or emplace_back.

[commit-bot: I haz the power, 2016-08-18 18:40:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:40:54]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[vasilii, 2016-08-19 09:38:12]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 09:38:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2016-08-19 09:43:46]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 09:44:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2016-08-19 09:52:30]

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
(right):

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm:75:
forms.push_back(base::WrapUnique(new autofill::PasswordForm(form)));
On 2016/08/18 18:39:19, vabr (Chromium) wrote:
> nit: Please use base::MakeUnique<autofill::PasswordForm>(form) instead.
> 
> See
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSa...
> for reasons.

Done.

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/passw...
File chrome/browser/ui/passwords/manage_passwords_state.cc (right):

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/passw...
chrome/browser/ui/passwords/manage_passwords_state.cc:27: base::WrapUnique(new
autofill::PasswordForm(*form_pair.second)));
On 2016/08/18 18:39:19, vabr (Chromium) wrote:
> nit: base::MakeUnique again, or the emplace_back you did above.
> 
> Also on other places in this file.

Done.

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/passwords/manage_password_items_view.cc (right):

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/passwords/manage_password_items_view.cc:276:
password_forms_rows_.push_back(base::WrapUnique(
On 2016/08/18 18:39:19, vabr (Chromium) wrote:
> Also here: what about MakeUnique or emplace_back?
> 
> (And below.)

Done.

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/views...
File
chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
(right):

https://codereview.chromium.org/2253233005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc:300:
local_credentials.push_back(
On 2016/08/18 18:39:19, vabr (Chromium) wrote:
> And in this file: please consider MakeUnique or emplace_back.

Done.

[vabr (Chromium), 2016-08-19 09:55:34]

Still LGTM, thanks!
Vaclav

[commit-bot: I haz the power, 2016-08-19 09:56:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 09:56:21]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[vasilii, 2016-08-19 10:54:08]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 10:54:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2016-08-19 11:35:50]

vasilii@chromium.org changed reviewers:
+ miguelg@chromium.org

[vasilii, 2016-08-19 11:35:50]

miguelg@chromium.org: Please review changes in 

update_password_infobar.cc

[commit-bot: I haz the power, 2016-08-19 11:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 11:40:24]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-08-19 19:20:21]

vasilii@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[vasilii, 2016-08-19 19:20:22]

dfalcantara@ please review
chrome/browser/ui/android/infobars/update_password_infobar.cc

[gone, 2016-08-19 20:04:20]

update_password_infobar.cc lgtm

[vasilii, 2016-08-22 08:32:21]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-08-22 08:32:22]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2253233005/#ps80001
(title: "android+")

[commit-bot: I haz the power, 2016-08-22 08:32:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 09:18:37]

Description was changed from

==========
Change ScopedVector to vector<unique_ptr> in the password's UI code.

In addition the code performs small related refactoring. No functional changes
should happen.

BUG=555132
==========

to

==========
Change ScopedVector to vector<unique_ptr> in the password's UI code.

In addition the code performs small related refactoring. No functional changes
should happen.

BUG=555132
==========

[commit-bot: I haz the power, 2016-08-22 09:18:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-22 09:20:34]

Description was changed from

==========
Change ScopedVector to vector<unique_ptr> in the password's UI code.

In addition the code performs small related refactoring. No functional changes
should happen.

BUG=555132
==========

to

==========
Change ScopedVector to vector<unique_ptr> in the password's UI code.

In addition the code performs small related refactoring. No functional changes
should happen.

BUG=555132

Committed: https://crrev.com/ca5afd3b53530d0422dc6add6a4227a2233e45f4
Cr-Commit-Position: refs/heads/master@{#413422}
==========

[commit-bot: I haz the power, 2016-08-22 09:20:35]

Patchset 5 (id:??) landed as
https://crrev.com/ca5afd3b53530d0422dc6add6a4227a2233e45f4
Cr-Commit-Position: refs/heads/master@{#413422}