Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4819)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
index 7fc213a1be73217be3e299c4c0a5555b2a63816d..73e46bb7194ca4a273cf822e79576307957d4259 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
@@ -9,6 +9,7 @@
#include "base/command_line.h"
#include "base/feature_list.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_samples.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
@@ -290,13 +291,14 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, AutoSignin) {
base::FeatureList::SetInstance(std::move(feature_list));
ASSERT_TRUE(base::FeatureList::IsEnabled(features::kCredentialManagementAPI));
- ScopedVector<autofill::PasswordForm> local_credentials;
test_form()->origin = GURL("https://example.com");
test_form()->display_name = base::ASCIIToUTF16("Peter");
test_form()->username_value = base::ASCIIToUTF16("pet12@gmail.com");
GURL icon_url("https://google.com/icon.png");
test_form()->icon_url = icon_url;
- local_credentials.push_back(new autofill::PasswordForm(*test_form()));
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials;
+ local_credentials.push_back(
+ base::MakeUnique<autofill::PasswordForm>(*test_form()));
// Prepare to capture the network request.
TestURLFetcherCallback url_callback;
@@ -322,11 +324,12 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, AutoSignin) {
}
IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, AutoSigninNoFocus) {
- ScopedVector<autofill::PasswordForm> local_credentials;
test_form()->origin = GURL("https://example.com");
test_form()->display_name = base::ASCIIToUTF16("Peter");
test_form()->username_value = base::ASCIIToUTF16("pet12@gmail.com");
- local_credentials.push_back(new autofill::PasswordForm(*test_form()));
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials;
+ local_credentials.push_back(
+ base::MakeUnique<autofill::PasswordForm>(*test_form()));
// Open another window with focus.
Browser* focused_window = CreateBrowser(browser()->profile());
« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698