chrome/browser/password_manager/update_password_infobar_delegate_android.cc - Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/update_password_infobar_delegate_android.cc

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android+ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/update_password_infobar_delegate_android.h ('k') | chrome/browser/ui/android/infobars/update_password_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/update_password_infobar_delegate_android.cc

diff --git a/chrome/browser/password_manager/update_password_infobar_delegate_android.cc b/chrome/browser/password_manager/update_password_infobar_delegate_android.cc

index 9fcb4792a608c1c716a2334a065993442440d991..57951ef04003b3e2d435ef3e8689daa5eb53fb80 100644

--- a/chrome/browser/password_manager/update_password_infobar_delegate_android.cc

+++ b/chrome/browser/password_manager/update_password_infobar_delegate_android.cc

@@ -52,7 +52,7 @@ bool UpdatePasswordInfoBarDelegate::ShowMultipleAccounts() const {

return GetCurrentForms().size() > 1 && !is_password_overriden;

}

-const std::vector<const autofill::PasswordForm*>&

+const std::vector<std::unique_ptr<autofill::PasswordForm>>&

UpdatePasswordInfoBarDelegate::GetCurrentForms() const {

return passwords_state_.GetCurrentForms();

}