Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/browser/ui/views/passwords/credentials_selection_view.h

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/credentials_selection_view.h
diff --git a/chrome/browser/ui/views/passwords/credentials_selection_view.h b/chrome/browser/ui/views/passwords/credentials_selection_view.h
index c20beedb36c9faa5590c6a155a6fd32917a45637..07b6f26aff73a99b7ef69196cae71f384f0f6c05 100644
--- a/chrome/browser/ui/views/passwords/credentials_selection_view.h
+++ b/chrome/browser/ui/views/passwords/credentials_selection_view.h
@@ -19,10 +19,8 @@ class ManagePasswordsBubbleModel;
// A view where the user can select a credential.
class CredentialsSelectionView : public views::View {
public:
- CredentialsSelectionView(
- ManagePasswordsBubbleModel* manage_passwords_bubble_model,
- const std::vector<const autofill::PasswordForm*>& password_forms,
- const base::string16& best_matched_username);
+ explicit CredentialsSelectionView(
+ ManagePasswordsBubbleModel* manage_passwords_bubble_model);
~CredentialsSelectionView() override;
// This methods also reports a user action.
@@ -30,11 +28,10 @@ class CredentialsSelectionView : public views::View {
private:
views::Combobox* GenerateUsernameCombobox(
- const std::vector<const autofill::PasswordForm*>& forms,
const base::string16& best_matched_username);
void ReportUserActionOnce(bool was_update_rejected, int selected_index);
- const std::vector<const autofill::PasswordForm*>& password_forms_;
+ const std::vector<autofill::PasswordForm>* password_forms_;
views::Combobox* combobox_;
int default_index_;
bool is_default_best_match_;

Powered by Google App Engine
This is Rietveld 408576698