Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4954)

Unified Diff: chrome/browser/ui/android/infobars/update_password_infobar.cc

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/infobars/update_password_infobar.cc
diff --git a/chrome/browser/ui/android/infobars/update_password_infobar.cc b/chrome/browser/ui/android/infobars/update_password_infobar.cc
index 39835ff7cfacb782bdfc4869d9c6ecb75dd22d88..4fb416af35b4556941a184970d56a405f02fb857 100644
--- a/chrome/browser/ui/android/infobars/update_password_infobar.cc
+++ b/chrome/browser/ui/android/infobars/update_password_infobar.cc
@@ -41,8 +41,8 @@ UpdatePasswordInfoBar::CreateRenderInfoBar(JNIEnv* env) {
std::vector<base::string16> usernames;
if (update_password_delegate->ShowMultipleAccounts()) {
- for (auto* password_form : update_password_delegate->GetCurrentForms())
- usernames.push_back(password_form->username_value);
+ for (const auto& form : update_password_delegate->GetCurrentForms())
+ usernames.push_back(form->username_value);
} else {
usernames.push_back(
update_password_delegate->get_username_for_single_account());

Powered by Google App Engine
This is Rietveld 408576698