chrome/browser/ui/cocoa/passwords/passwords_bubble_browsertest.mm - Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/passwords_bubble_browsertest.mm

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android+ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/passwords_bubble_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/passwords/passwords_bubble_browsertest.mm b/chrome/browser/ui/cocoa/passwords/passwords_bubble_browsertest.mm

index ccc293b00f0b84d1b52d0fa6195c62d0603c7787..df6a6bcefce0b1779b1844fcf99d9982807ff702 100644

--- a/chrome/browser/ui/cocoa/passwords/passwords_bubble_browsertest.mm

+++ b/chrome/browser/ui/cocoa/passwords/passwords_bubble_browsertest.mm

@@ -131,8 +131,8 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleTest, DoubleOpenBubble) {

IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleTest, DoubleOpenDifferentBubbles) {

// Open the autosignin bubble first.

DoWithSwizzledNSWindow(^{

- ScopedVector<autofill::PasswordForm> local_credentials;

- local_credentials.push_back(new autofill::PasswordForm(*test_form()));

+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials;

+ local_credentials.emplace_back(new autofill::PasswordForm(*test_form()));

SetupAutoSignin(std::move(local_credentials));

});

EXPECT_TRUE(controller());