chrome/browser/ui/passwords/manage_passwords_test.cc - Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_test.cc

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android+ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_test.h ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_test.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_test.cc b/chrome/browser/ui/passwords/manage_passwords_test.cc

index eedc0a9a3d09d63cde5b80c4d769321378b90ea3..ffc06c362958ad8d66efca901ece17d8a9c4a916 100644

--- a/chrome/browser/ui/passwords/manage_passwords_test.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_test.cc

@@ -83,7 +83,7 @@ void ManagePasswordsTest::SetupAutomaticPassword() {

}

void ManagePasswordsTest::SetupAutoSignin(

- ScopedVector<autofill::PasswordForm> local_credentials) {

+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials) {

ASSERT_FALSE(local_credentials.empty());

GURL origin = local_credentials[0]->origin;

GetController()->OnAutoSignin(std::move(local_credentials), origin);