Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_test.cc

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_test.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_test.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 password_manager::StubPasswordManagerDriver driver; 76 password_manager::StubPasswordManagerDriver driver;
77 77
78 std::unique_ptr<password_manager::PasswordFormManager> test_form_manager( 78 std::unique_ptr<password_manager::PasswordFormManager> test_form_manager(
79 new password_manager::PasswordFormManager( 79 new password_manager::PasswordFormManager(
80 nullptr, &client, driver.AsWeakPtr(), *test_form(), 80 nullptr, &client, driver.AsWeakPtr(), *test_form(),
81 base::WrapUnique(new password_manager::StubFormSaver))); 81 base::WrapUnique(new password_manager::StubFormSaver)));
82 GetController()->OnAutomaticPasswordSave(std::move(test_form_manager)); 82 GetController()->OnAutomaticPasswordSave(std::move(test_form_manager));
83 } 83 }
84 84
85 void ManagePasswordsTest::SetupAutoSignin( 85 void ManagePasswordsTest::SetupAutoSignin(
86 ScopedVector<autofill::PasswordForm> local_credentials) { 86 std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials) {
87 ASSERT_FALSE(local_credentials.empty()); 87 ASSERT_FALSE(local_credentials.empty());
88 GURL origin = local_credentials[0]->origin; 88 GURL origin = local_credentials[0]->origin;
89 GetController()->OnAutoSignin(std::move(local_credentials), origin); 89 GetController()->OnAutoSignin(std::move(local_credentials), origin);
90 } 90 }
91 91
92 std::unique_ptr<base::HistogramSamples> ManagePasswordsTest::GetSamples( 92 std::unique_ptr<base::HistogramSamples> ManagePasswordsTest::GetSamples(
93 const char* histogram) { 93 const char* histogram) {
94 // Ensure that everything has been properly recorded before pulling samples. 94 // Ensure that everything has been properly recorded before pulling samples.
95 content::RunAllPendingInMessageLoop(); 95 content::RunAllPendingInMessageLoop();
96 return histogram_tester_.GetHistogramSamplesSinceCreation(histogram); 96 return histogram_tester_.GetHistogramSamplesSinceCreation(histogram);
97 } 97 }
98 98
99 PasswordsClientUIDelegate* ManagePasswordsTest::GetController() { 99 PasswordsClientUIDelegate* ManagePasswordsTest::GetController() {
100 return PasswordsClientUIDelegateFromWebContents( 100 return PasswordsClientUIDelegateFromWebContents(
101 browser()->tab_strip_model()->GetActiveWebContents()); 101 browser()->tab_strip_model()->GetActiveWebContents());
102 } 102 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_test.h ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698