chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm - Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android+ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/passwords_list_view_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

index 696e92eac5c3f35ff725541ed02be47fbf95b623..910a07f4e78fa08b07b57ddfe2b6ff4e351120a7 100644

--- a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

@@ -42,11 +42,9 @@

- (NSView*)createPasswordView {

if (self.model->pending_password().username_value.empty())

return nil;

- std::vector<const autofill::PasswordForm*> password_forms;

- password_forms.push_back(&self.model->pending_password());

passwordItem_.reset([[PasswordsListViewController alloc]

- initWithModel:self.model

- forms:password_forms]);

+ initWithModelAndForm:self.model

+ form:&self.model->pending_password()]);

return [passwordItem_ view];

}