Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: chrome/browser/password_manager/account_chooser_dialog_android.h

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/account_chooser_dialog_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/account_chooser_dialog_android.h
diff --git a/chrome/browser/password_manager/account_chooser_dialog_android.h b/chrome/browser/password_manager/account_chooser_dialog_android.h
index 7326976d8962a54421bd5ff0f64366c4eb7e91f2..3ddcf25ce1413f2f3ab645917775326c129d51b6 100644
--- a/chrome/browser/password_manager/account_chooser_dialog_android.h
+++ b/chrome/browser/password_manager/account_chooser_dialog_android.h
@@ -11,7 +11,6 @@
#include "base/android/jni_android.h"
#include "base/macros.h"
-#include "base/memory/scoped_vector.h"
#include "chrome/browser/ui/passwords/manage_passwords_state.h"
#include "content/public/browser/web_contents_observer.h"
@@ -29,8 +28,8 @@ class AccountChooserDialogAndroid : public content::WebContentsObserver {
public:
AccountChooserDialogAndroid(
content::WebContents* web_contents,
- ScopedVector<autofill::PasswordForm> local_credentials,
- ScopedVector<autofill::PasswordForm> federated_credentials,
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
+ std::vector<std::unique_ptr<autofill::PasswordForm>> federation_providers,
const GURL& origin,
const ManagePasswordsState::CredentialsCallback& callback);
@@ -61,11 +60,11 @@ class AccountChooserDialogAndroid : public content::WebContentsObserver {
private:
void OnDialogCancel();
- const std::vector<const autofill::PasswordForm*>& local_credentials_forms()
- const;
+ const std::vector<std::unique_ptr<autofill::PasswordForm>>&
+ local_credentials_forms() const;
- const std::vector<const autofill::PasswordForm*>&
- federated_credentials_forms() const;
+ const std::vector<std::unique_ptr<autofill::PasswordForm>>&
+ federation_providers_forms() const;
void ChooseCredential(size_t index,
password_manager::CredentialType type,
« no previous file with comments | « no previous file | chrome/browser/password_manager/account_chooser_dialog_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698