Change ScopedVector to vector<unique_ptr> in the password's UI code.

chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "components/password_manager/core/browser/mock_password_store.h"
 #include "components/password_manager/core/browser/password_manager_test_utils.h"
@@ skipping 39 matching lines @@
   }
   return model_.get();
 }
 
 void ManagePasswordsControllerTest::SetUpSavePendingState(bool empty_username) {
   autofill::PasswordForm form;
   if (!empty_username) {
     form.username_value = base::ASCIIToUTF16("username");
   }
   EXPECT_CALL(*ui_controller_, GetPendingPassword()).WillOnce(ReturnRef(form));
-  std::vector<const autofill::PasswordForm*> forms;
+  std::vector<std::unique_ptr<autofill::PasswordForm>> forms;
   EXPECT_CALL(*ui_controller_, GetCurrentForms()).WillOnce(ReturnRef(forms));
   GURL origin(kSiteOrigin);
   EXPECT_CALL(*ui_controller_, GetOrigin()).WillOnce(ReturnRef(origin));
   EXPECT_CALL(*ui_controller_, GetState())
       .WillOnce(Return(password_manager::ui::PENDING_PASSWORD_STATE));
   GetModelAndCreateIfNull();
   ASSERT_TRUE(testing::Mock::VerifyAndClearExpectations(ui_controller_.get()));
 }
 
 void ManagePasswordsControllerTest::SetUpUpdatePendingState(
     bool multiple_forms) {
   autofill::PasswordForm form;
   EXPECT_CALL(*ui_controller_, GetPendingPassword()).WillOnce(ReturnRef(form));
-  std::vector<const autofill::PasswordForm*> forms;
-  forms.push_back(&form);
+  std::vector<std::unique_ptr<autofill::PasswordForm>> forms;
+  forms.push_back(base::WrapUnique(new autofill::PasswordForm(form)));

[vabr (Chromium), 2016/08/18 18:39:19]

nit: Please use base::MakeUnique<autofill::PasswordForm>(form) instead.

See
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSa...
for reasons.

[vasilii, 2016/08/19 09:52:30]

Done.

   if (multiple_forms) {
-    forms.push_back(&form);
+    forms.push_back(base::WrapUnique(new autofill::PasswordForm(form)));
   }
   EXPECT_CALL(*ui_controller_, GetCurrentForms()).WillOnce(ReturnRef(forms));
   GURL origin(kSiteOrigin);
   EXPECT_CALL(*ui_controller_, GetOrigin()).WillOnce(ReturnRef(origin));
   EXPECT_CALL(*ui_controller_, GetState())
       .WillOnce(Return(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE));
   GetModelAndCreateIfNull();
   ASSERT_TRUE(testing::Mock::VerifyAndClearExpectations(ui_controller_.get()));
 }
 
@@ skipping 28 matching lines @@
 @synthesize dismissed = _dismissed;
 
 - (void)viewShouldDismiss {
   _dismissed = YES;
 }
 
 - (void)refreshBubble {
 }
 
 @end