Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc |
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc |
index 97025e8f84fd8c94675731b8f761bd02e61ada5b..18f8f6092406bbb67eb70cb75802a38bfac020af 100644 |
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc |
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc |
@@ -309,7 +309,7 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordAutofilled) { |
EXPECT_EQ(kTestUsername, controller()->GetCurrentForms()[0]->username_value); |
// Controller should store a separate copy of the form as it doesn't own it. |
- EXPECT_NE(test_form_ptr, controller()->GetCurrentForms()[0]); |
+ EXPECT_NE(test_form_ptr, controller()->GetCurrentForms()[0].get()); |
ExpectIconStateIs(password_manager::ui::MANAGE_STATE); |
} |
@@ -518,9 +518,9 @@ TEST_F(ManagePasswordsUIControllerTest, AutomaticPasswordSave) { |
} |
TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialLocal) { |
- ScopedVector<autofill::PasswordForm> local_credentials; |
- local_credentials.push_back(new autofill::PasswordForm(test_local_form())); |
- ScopedVector<autofill::PasswordForm> federated_credentials; |
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials; |
+ local_credentials.emplace_back(new autofill::PasswordForm(test_local_form())); |
+ std::vector<std::unique_ptr<autofill::PasswordForm>> federated_credentials; |
GURL origin("http://example.com"); |
PasswordDialogController* dialog_controller = nullptr; |
EXPECT_CALL(*controller(), CreateAccountChooser(_)).WillOnce( |
@@ -551,10 +551,10 @@ TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialLocal) { |
} |
TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialLocalButFederated) { |
- ScopedVector<autofill::PasswordForm> local_credentials; |
- local_credentials.push_back( |
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials; |
+ local_credentials.emplace_back( |
new autofill::PasswordForm(test_federated_form())); |
- ScopedVector<autofill::PasswordForm> federated_credentials; |
+ std::vector<std::unique_ptr<autofill::PasswordForm>> federated_credentials; |
GURL origin("http://example.com"); |
PasswordDialogController* dialog_controller = nullptr; |
EXPECT_CALL(*controller(), CreateAccountChooser(_)).WillOnce( |
@@ -585,9 +585,9 @@ TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialLocalButFederated) { |
} |
TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialCancel) { |
- ScopedVector<autofill::PasswordForm> local_credentials; |
- local_credentials.push_back(new autofill::PasswordForm(test_local_form())); |
- ScopedVector<autofill::PasswordForm> federated_credentials; |
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials; |
+ local_credentials.emplace_back(new autofill::PasswordForm(test_local_form())); |
+ std::vector<std::unique_ptr<autofill::PasswordForm>> federated_credentials; |
GURL origin("http://example.com"); |
PasswordDialogController* dialog_controller = nullptr; |
EXPECT_CALL(*controller(), CreateAccountChooser(_)).WillOnce( |
@@ -610,8 +610,8 @@ TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialCancel) { |
} |
TEST_F(ManagePasswordsUIControllerTest, AutoSignin) { |
- ScopedVector<autofill::PasswordForm> local_credentials; |
- local_credentials.push_back(new autofill::PasswordForm(test_local_form())); |
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials; |
+ local_credentials.emplace_back(new autofill::PasswordForm(test_local_form())); |
EXPECT_CALL(*controller(), OnUpdateBubbleAndIconVisibility()); |
controller()->OnAutoSignin(std::move(local_credentials), |
test_local_form().origin); |
@@ -678,8 +678,8 @@ TEST_F(ManagePasswordsUIControllerTest, AutoSigninFirstRunAfterNavigation) { |
} |
TEST_F(ManagePasswordsUIControllerTest, AutofillDuringAutoSignin) { |
- ScopedVector<autofill::PasswordForm> local_credentials; |
- local_credentials.push_back(new autofill::PasswordForm(test_local_form())); |
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials; |
+ local_credentials.emplace_back(new autofill::PasswordForm(test_local_form())); |
EXPECT_CALL(*controller(), OnUpdateBubbleAndIconVisibility()); |
controller()->OnAutoSignin(std::move(local_credentials), |
test_local_form().origin); |
@@ -748,8 +748,8 @@ TEST_F(ManagePasswordsUIControllerTest, ConfirmationStatePasswordAutofilled) { |
TEST_F(ManagePasswordsUIControllerTest, OpenBubbleTwice) { |
// Open the autosignin bubble. |
- ScopedVector<autofill::PasswordForm> local_credentials; |
- local_credentials.push_back(new autofill::PasswordForm(test_local_form())); |
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials; |
+ local_credentials.emplace_back(new autofill::PasswordForm(test_local_form())); |
EXPECT_CALL(*controller(), OnUpdateBubbleAndIconVisibility()); |
controller()->OnAutoSignin(std::move(local_credentials), |
test_local_form().origin); |
@@ -759,7 +759,7 @@ TEST_F(ManagePasswordsUIControllerTest, OpenBubbleTwice) { |
controller()->GetModelDelegateProxy(); |
// Open the bubble again. |
- local_credentials.push_back(new autofill::PasswordForm(test_local_form())); |
+ local_credentials.emplace_back(new autofill::PasswordForm(test_local_form())); |
EXPECT_CALL(*controller(), OnUpdateBubbleAndIconVisibility()); |
controller()->OnAutoSignin(std::move(local_credentials), |
test_local_form().origin); |