Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: chrome/browser/ui/views/passwords/manage_password_items_view.h

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_password_items_view.h
diff --git a/chrome/browser/ui/views/passwords/manage_password_items_view.h b/chrome/browser/ui/views/passwords/manage_password_items_view.h
index eae31d0773499a4163d68cb6d2d8ad09d3be37b0..66c5819a23123e1c83c2370d635f8417f1f1323a 100644
--- a/chrome/browser/ui/views/passwords/manage_password_items_view.h
+++ b/chrome/browser/ui/views/passwords/manage_password_items_view.h
@@ -5,10 +5,10 @@
#ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORD_ITEMS_VIEW_H_
#define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORD_ITEMS_VIEW_H_
+#include <memory>
#include <vector>
#include "base/macros.h"
-#include "base/memory/scoped_vector.h"
#include "components/autofill/core/common/password_form.h"
#include "ui/views/view.h"
@@ -24,7 +24,10 @@ class ManagePasswordItemsView : public views::View {
public:
ManagePasswordItemsView(
ManagePasswordsBubbleModel* manage_passwords_bubble_model,
- const std::vector<const autofill::PasswordForm*>& password_forms);
+ const std::vector<autofill::PasswordForm>* password_forms);
+ ManagePasswordItemsView(
+ ManagePasswordsBubbleModel* manage_passwords_bubble_model,
+ const autofill::PasswordForm* password_form);
private:
class PasswordFormRow;
@@ -38,7 +41,7 @@ class ManagePasswordItemsView : public views::View {
// Changes the views according to the state of |password_forms_rows_|.
void Refresh();
- ScopedVector<PasswordFormRow> password_forms_rows_;
+ std::vector<std::unique_ptr<PasswordFormRow>> password_forms_rows_;
ManagePasswordsBubbleModel* model_;
DISALLOW_COPY_AND_ASSIGN(ManagePasswordItemsView);

Powered by Google App Engine
This is Rietveld 408576698