chrome/browser/ui/passwords/manage_passwords_test.h - Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_test.h

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android+ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state_unittest.cc ('k') | chrome/browser/ui/passwords/manage_passwords_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_test.h

diff --git a/chrome/browser/ui/passwords/manage_passwords_test.h b/chrome/browser/ui/passwords/manage_passwords_test.h

index c0969268d1da969baf60e70a11b79ae39e198688..ce5ac17ea1f4176b469af9d57f38134892bf1269 100644

--- a/chrome/browser/ui/passwords/manage_passwords_test.h

+++ b/chrome/browser/ui/passwords/manage_passwords_test.h

@@ -8,7 +8,6 @@

#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_vector.h"

#include "base/metrics/histogram_samples.h"

#include "base/test/histogram_tester.h"

#include "chrome/test/base/in_process_browser_test.h"

@@ -47,7 +46,7 @@ class ManagePasswordsTest : public InProcessBrowserTest {

// Put the controller, icon, and bubble into an auto sign-in state.

void SetupAutoSignin(

- ScopedVector<autofill::PasswordForm> local_credentials);

+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials);

// Get samples for |histogram|.

std::unique_ptr<base::HistogramSamples> GetSamples(const char* histogram);