Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3915)

Unified Diff: chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.h

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.h
diff --git a/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.h b/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.h
index 353e4271d68f8b1591cdbcf1dab5d7a23d68f845..60ebddb69de2d9e5c1c961ab20f13594b279b273 100644
--- a/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.h
+++ b/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.h
@@ -17,7 +17,7 @@ struct PasswordForm;
class ManagePasswordsBubbleModel;
-typedef std::vector<const autofill::PasswordForm*> PasswordFormsVector;
+typedef std::vector<autofill::PasswordForm> PasswordFormsVector;
// Handles callbacks from ManagePasswordItemViewController.
@protocol PasswordItemDelegate<NSObject>
@@ -39,8 +39,10 @@ typedef std::vector<const autofill::PasswordForm*> PasswordFormsVector;
CGFloat firstColumnMaxWidth_;
CGFloat secondColumnMaxWidth_;
}
-- (id)initWithModel:(ManagePasswordsBubbleModel*)model
- forms:(const PasswordFormsVector&)password_forms;
+- (id)initWithModelAndForms:(ManagePasswordsBubbleModel*)model
+ forms:(const PasswordFormsVector*)password_forms;
+- (id)initWithModelAndForm:(ManagePasswordsBubbleModel*)model
+ form:(const autofill::PasswordForm*)form;
@end
@interface PasswordsListViewController (Testing)

Powered by Google App Engine
This is Rietveld 408576698