Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3745)

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm
index 2aa5d6b5dd09732a8192386a63736074921ed19d..0eb65deadd1266cea4dc3743a95adbcb33867690 100644
--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm
@@ -69,15 +69,18 @@ TEST_F(ManagePasswordsViewControllerTest,
TEST_F(ManagePasswordsViewControllerTest,
ShouldShowAllPasswordItemsWhenPasswordsExistForSite) {
// Add a few password entries.
- autofill::PasswordForm form1;
- form1.username_value = base::ASCIIToUTF16("username1");
- form1.password_value = base::ASCIIToUTF16("password1");
-
- autofill::PasswordForm form2;
- form2.username_value = base::ASCIIToUTF16("username2");
- form2.password_value = base::ASCIIToUTF16("password2");
-
- SetUpManageState({&form1, &form2});
+ std::unique_ptr<autofill::PasswordForm> form1(new autofill::PasswordForm);
+ form1->username_value = base::ASCIIToUTF16("username1");
+ form1->password_value = base::ASCIIToUTF16("password1");
+
+ std::unique_ptr<autofill::PasswordForm> form2(new autofill::PasswordForm);
+ form2->username_value = base::ASCIIToUTF16("username2");
+ form2->password_value = base::ASCIIToUTF16("password2");
+
+ VectorConstFormPtr forms;
+ forms.push_back(std::move(form1));
+ forms.push_back(std::move(form2));
+ SetUpManageState(forms);
// Check the view state.
ASSERT_TRUE([controller() passwordsListController]);

Powered by Google App Engine
This is Rietveld 408576698