Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: chrome/browser/ui/passwords/passwords_client_ui_delegate.h

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/passwords_client_ui_delegate.h
diff --git a/chrome/browser/ui/passwords/passwords_client_ui_delegate.h b/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
index b4198e5102ef80069b5dbb52f6e5baaeff5dda44..fe99add5b523e071cafd54c578f223f0524405bc 100644
--- a/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
+++ b/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
@@ -9,7 +9,6 @@
#include <vector>
#include "base/callback.h"
-#include "base/memory/scoped_vector.h"
#include "components/autofill/core/common/password_form.h"
namespace content {
@@ -45,15 +44,16 @@ class PasswordsClientUIDelegate {
// a decision. If the UI isn't shown the method returns false and doesn't call
// |callback|.
virtual bool OnChooseCredentials(
- ScopedVector<autofill::PasswordForm> local_credentials,
- ScopedVector<autofill::PasswordForm> federated_credentials,
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
+ std::vector<std::unique_ptr<autofill::PasswordForm>>
+ federated_credentials,
const GURL& origin,
const base::Callback<void(const autofill::PasswordForm*)>& callback) = 0;
// Called when user is auto signed in to the site. |local_forms[0]| contains
// the credential returned to the site. |origin| is a URL of the site.
virtual void OnAutoSignin(
- ScopedVector<autofill::PasswordForm> local_forms,
+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_forms,
const GURL& origin) = 0;
// Called when it's the right time to enable autosign-in explicitly.

Powered by Google App Engine
This is Rietveld 408576698