chrome/browser/ui/passwords/passwords_model_delegate.h - Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/passwords_model_delegate.h

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android+ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/passwords_client_ui_delegate.h ('k') | chrome/browser/ui/passwords/passwords_model_delegate_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/passwords_model_delegate.h

diff --git a/chrome/browser/ui/passwords/passwords_model_delegate.h b/chrome/browser/ui/passwords/passwords_model_delegate.h

index fa99936ce33851c50d8c316f696a12a716f0dfee..2c560d465f214a4bc3493a1e87e2ac60ddb25783 100644

--- a/chrome/browser/ui/passwords/passwords_model_delegate.h

+++ b/chrome/browser/ui/passwords/passwords_model_delegate.h

@@ -46,11 +46,11 @@ class PasswordsModelDelegate {

virtual bool IsPasswordOverridden() const = 0;

// Returns current local forms for the current page.

- virtual const std::vector<const autofill::PasswordForm*>&

+ virtual const std::vector<std::unique_ptr<autofill::PasswordForm>>&

GetCurrentForms() const = 0;

// Returns possible identity provider's credentials for the current site.

- virtual const std::vector<const autofill::PasswordForm*>&

+ virtual const std::vector<std::unique_ptr<autofill::PasswordForm>>&

GetFederatedForms() const = 0;

// For PENDING_PASSWORD_STATE state returns the current statistics for