Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 ~ManagePasswordsUIController() override; 45 ~ManagePasswordsUIController() override;
46 46
47 // PasswordsClientUIDelegate: 47 // PasswordsClientUIDelegate:
48 void OnPasswordSubmitted( 48 void OnPasswordSubmitted(
49 std::unique_ptr<password_manager::PasswordFormManager> form_manager) 49 std::unique_ptr<password_manager::PasswordFormManager> form_manager)
50 override; 50 override;
51 void OnUpdatePasswordSubmitted( 51 void OnUpdatePasswordSubmitted(
52 std::unique_ptr<password_manager::PasswordFormManager> form_manager) 52 std::unique_ptr<password_manager::PasswordFormManager> form_manager)
53 override; 53 override;
54 bool OnChooseCredentials( 54 bool OnChooseCredentials(
55 ScopedVector<autofill::PasswordForm> local_credentials, 55 std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
56 ScopedVector<autofill::PasswordForm> federated_credentials, 56 std::vector<std::unique_ptr<autofill::PasswordForm>>
57 federated_credentials,
57 const GURL& origin, 58 const GURL& origin,
58 const ManagePasswordsState::CredentialsCallback& callback) override; 59 const ManagePasswordsState::CredentialsCallback& callback) override;
59 void OnAutoSignin(ScopedVector<autofill::PasswordForm> local_forms, 60 void OnAutoSignin(
60 const GURL& origin) override; 61 std::vector<std::unique_ptr<autofill::PasswordForm>> local_forms,
62 const GURL& origin) override;
61 void OnPromptEnableAutoSignin() override; 63 void OnPromptEnableAutoSignin() override;
62 void OnAutomaticPasswordSave( 64 void OnAutomaticPasswordSave(
63 std::unique_ptr<password_manager::PasswordFormManager> form_manager) 65 std::unique_ptr<password_manager::PasswordFormManager> form_manager)
64 override; 66 override;
65 void OnPasswordAutofilled( 67 void OnPasswordAutofilled(
66 const autofill::PasswordFormMap& password_form_map, 68 const autofill::PasswordFormMap& password_form_map,
67 const GURL& origin, 69 const GURL& origin,
68 const std::vector<std::unique_ptr<autofill::PasswordForm>>* 70 const std::vector<std::unique_ptr<autofill::PasswordForm>>*
69 federated_matches) override; 71 federated_matches) override;
70 72
(...skipping 10 matching lines...) Expand all
81 } 83 }
82 84
83 base::WeakPtr<PasswordsModelDelegate> GetModelDelegateProxy(); 85 base::WeakPtr<PasswordsModelDelegate> GetModelDelegateProxy();
84 86
85 // PasswordsModelDelegate: 87 // PasswordsModelDelegate:
86 content::WebContents* GetWebContents() const override; 88 content::WebContents* GetWebContents() const override;
87 const GURL& GetOrigin() const override; 89 const GURL& GetOrigin() const override;
88 password_manager::ui::State GetState() const override; 90 password_manager::ui::State GetState() const override;
89 const autofill::PasswordForm& GetPendingPassword() const override; 91 const autofill::PasswordForm& GetPendingPassword() const override;
90 bool IsPasswordOverridden() const override; 92 bool IsPasswordOverridden() const override;
91 const std::vector<const autofill::PasswordForm*>& GetCurrentForms() 93 const std::vector<std::unique_ptr<autofill::PasswordForm>>& GetCurrentForms()
92 const override; 94 const override;
93 const std::vector<const autofill::PasswordForm*>& GetFederatedForms() 95 const std::vector<std::unique_ptr<autofill::PasswordForm>>&
94 const override; 96 GetFederatedForms() const override;
95 password_manager::InteractionsStats* GetCurrentInteractionStats() const 97 password_manager::InteractionsStats* GetCurrentInteractionStats() const
96 override; 98 override;
97 void OnBubbleShown() override; 99 void OnBubbleShown() override;
98 void OnBubbleHidden() override; 100 void OnBubbleHidden() override;
99 void OnNoInteractionOnUpdate() override; 101 void OnNoInteractionOnUpdate() override;
100 void OnNopeUpdateClicked() override; 102 void OnNopeUpdateClicked() override;
101 void NeverSavePassword() override; 103 void NeverSavePassword() override;
102 void SavePassword() override; 104 void SavePassword() override;
103 void UpdatePassword(const autofill::PasswordForm& password_form) override; 105 void UpdatePassword(const autofill::PasswordForm& password_form) override;
104 void ChooseCredential( 106 void ChooseCredential(
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 // Thus, OnBubbleHidden() can be called after the new one is shown. By that 186 // Thus, OnBubbleHidden() can be called after the new one is shown. By that
185 // time the internal state of ManagePasswordsUIController has nothing to do 187 // time the internal state of ManagePasswordsUIController has nothing to do
186 // with the old bubble. 188 // with the old bubble.
187 // Invalidating all the weak pointers will detach the current bubble. 189 // Invalidating all the weak pointers will detach the current bubble.
188 base::WeakPtrFactory<ManagePasswordsUIController> weak_ptr_factory_; 190 base::WeakPtrFactory<ManagePasswordsUIController> weak_ptr_factory_;
189 191
190 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController); 192 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
191 }; 193 };
192 194
193 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 195 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_test.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698