Change ScopedVector to vector<unique_ptr> in the password's UI code.

chrome/browser/ui/views/passwords/manage_password_items_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/manage_password_items_view.h"
 
 #include <numeric>
 
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
 #include "chrome/grit/generated_resources.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/resources/grit/ui_resources.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/button/image_button.h"
@@ skipping 240 matching lines @@
 }
 
 void ManagePasswordItemsView::PasswordFormRow::ResetControls() {
   delete_button_ = nullptr;
   undo_link_ = nullptr;
 }
 
 // ManagePasswordItemsView
 ManagePasswordItemsView::ManagePasswordItemsView(
     ManagePasswordsBubbleModel* manage_passwords_bubble_model,
-    const std::vector<const autofill::PasswordForm*>& password_forms)
+    const std::vector<autofill::PasswordForm>* password_forms)
     : model_(manage_passwords_bubble_model) {
   int fixed_height = PasswordFormRow::GetFixedHeight(model_->state());
-  for (const autofill::PasswordForm* password_form : password_forms) {
-    if (!password_form->is_public_suffix_match)
-      password_forms_rows_.push_back(
-          new PasswordFormRow(this, password_form, fixed_height));
+  for (const auto& password_form : *password_forms) {
+    if (!password_form.is_public_suffix_match)
+      password_forms_rows_.push_back(base::WrapUnique(

[vabr (Chromium), 2016/08/18 18:39:19]

Also here: what about MakeUnique or emplace_back?

(And below.)

[vasilii, 2016/08/19 09:52:30]

Done.

+          new PasswordFormRow(this, &password_form, fixed_height)));
   }
   AddRows();
 }
 
+ManagePasswordItemsView::ManagePasswordItemsView(
+    ManagePasswordsBubbleModel* manage_passwords_bubble_model,
+    const autofill::PasswordForm* password_form)
+    : model_(manage_passwords_bubble_model) {
+  password_forms_rows_.push_back(
+      base::WrapUnique(new PasswordFormRow(this, password_form, 0)));
+  AddRows();
+}
+
 ManagePasswordItemsView::~ManagePasswordItemsView() = default;
 
 void ManagePasswordItemsView::AddRows() {
   views::GridLayout* layout = new views::GridLayout(this);
   SetLayoutManager(layout);
-  for (auto* row : password_forms_rows_) {
+  for (const std::unique_ptr<PasswordFormRow>& row : password_forms_rows_) {
     if (row != password_forms_rows_[0])
       layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
     row->AddRow(layout);
   }
   GetLayoutManager()->Layout(this);
 }
 
 void ManagePasswordItemsView::NotifyPasswordFormStatusChanged(
     const autofill::PasswordForm& password_form, bool deleted) {
   Refresh();
   // After the view is consistent, notify the model that the password needs to
   // be updated (either removed or put back into the store, as appropriate.
   model_->OnPasswordAction(password_form,
                            deleted
                                ? ManagePasswordsBubbleModel::REMOVE_PASSWORD
                                : ManagePasswordsBubbleModel::ADD_PASSWORD);
 }
 
 void ManagePasswordItemsView::Refresh() {
   DCHECK_NE(password_manager::ui::PENDING_PASSWORD_STATE, model_->state());
   RemoveAllChildViews(true);
   AddRows();
 }