Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1860)

Unified Diff: chrome/browser/password_manager/account_chooser_dialog_android_unittest.cc

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/account_chooser_dialog_android_unittest.cc
diff --git a/chrome/browser/password_manager/account_chooser_dialog_android_unittest.cc b/chrome/browser/password_manager/account_chooser_dialog_android_unittest.cc
index da58fdb0ddc97471122ea9f814cd48ff0ecc58b3..ac828684ef4b08c4fb19fae2e87d525c7a22bed2 100644
--- a/chrome/browser/password_manager/account_chooser_dialog_android_unittest.cc
+++ b/chrome/browser/password_manager/account_chooser_dialog_android_unittest.cc
@@ -49,7 +49,7 @@ class AccountChooserDialogAndroidTest : public ChromeRenderViewHostTestHarness {
AccountChooserDialogAndroid* CreateDialogManyAccounts();
AccountChooserDialogAndroid* CreateDialog(
- ScopedVector<autofill::PasswordForm> credentials);
+ std::vector<std::unique_ptr<autofill::PasswordForm>> credentials);
private:
DISALLOW_COPY_AND_ASSIGN(AccountChooserDialogAndroidTest);
@@ -62,8 +62,8 @@ void AccountChooserDialogAndroidTest::SetUp() {
}
AccountChooserDialogAndroid* AccountChooserDialogAndroidTest::CreateDialog(
- ScopedVector<autofill::PasswordForm> credentials) {
- ScopedVector<autofill::PasswordForm> deprecated_federated;
+ std::vector<std::unique_ptr<autofill::PasswordForm>> credentials) {
+ std::vector<std::unique_ptr<autofill::PasswordForm>> deprecated_federated;
return new AccountChooserDialogAndroid(
web_contents(), std::move(credentials), std::move(deprecated_federated),
GURL("https://example.com"),
@@ -73,14 +73,14 @@ AccountChooserDialogAndroid* AccountChooserDialogAndroidTest::CreateDialog(
AccountChooserDialogAndroid*
AccountChooserDialogAndroidTest::CreateDialogOneAccount() {
- ScopedVector<autofill::PasswordForm> credentials;
+ std::vector<std::unique_ptr<autofill::PasswordForm>> credentials;
credentials.push_back(CreatePasswordFormFromDataForTesting(kFormData));
return CreateDialog(std::move(credentials));
}
AccountChooserDialogAndroid*
AccountChooserDialogAndroidTest::CreateDialogManyAccounts() {
- ScopedVector<autofill::PasswordForm> credentials;
+ std::vector<std::unique_ptr<autofill::PasswordForm>> credentials;
credentials.push_back(CreatePasswordFormFromDataForTesting(kFormData));
credentials.push_back(CreatePasswordFormFromDataForTesting(kFormData));
return CreateDialog(std::move(credentials));

Powered by Google App Engine
This is Rietveld 408576698