chrome/browser/ui/passwords/manage_passwords_ui_controller.h - Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android+ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_test.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

index d075a487946ab3c98dfb722f24f0d9391af7b4d9..3188de8e038f77ded362ea2b529d41841880c14f 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

@@ -52,12 +52,14 @@ class ManagePasswordsUIController

std::unique_ptr<password_manager::PasswordFormManager> form_manager)

override;

bool OnChooseCredentials(

- ScopedVector<autofill::PasswordForm> local_credentials,

- ScopedVector<autofill::PasswordForm> federated_credentials,

+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,

+ std::vector<std::unique_ptr<autofill::PasswordForm>>

+ federated_credentials,

const GURL& origin,

const ManagePasswordsState::CredentialsCallback& callback) override;

- void OnAutoSignin(ScopedVector<autofill::PasswordForm> local_forms,

- const GURL& origin) override;

+ void OnAutoSignin(

+ std::vector<std::unique_ptr<autofill::PasswordForm>> local_forms,

+ const GURL& origin) override;

void OnPromptEnableAutoSignin() override;

void OnAutomaticPasswordSave(

std::unique_ptr<password_manager::PasswordFormManager> form_manager)

@@ -88,10 +90,10 @@ class ManagePasswordsUIController

password_manager::ui::State GetState() const override;

const autofill::PasswordForm& GetPendingPassword() const override;

bool IsPasswordOverridden() const override;

- const std::vector<const autofill::PasswordForm*>& GetCurrentForms()

- const override;

- const std::vector<const autofill::PasswordForm*>& GetFederatedForms()

+ const std::vector<std::unique_ptr<autofill::PasswordForm>>& GetCurrentForms()

const override;

+ const std::vector<std::unique_ptr<autofill::PasswordForm>>&

+ GetFederatedForms() const override;

password_manager::InteractionsStats* GetCurrentInteractionStats() const

override;

void OnBubbleShown() override;