Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2827)

Unified Diff: chrome/browser/ui/views/passwords/manage_password_items_view.cc

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android+ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_password_items_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_password_items_view.cc b/chrome/browser/ui/views/passwords/manage_password_items_view.cc
index 97cae00a0e457b8b9bac5f2ec054e427bfa7dbef..28f2729eb3625044ae0591d4558da6ba766cfb25 100644
--- a/chrome/browser/ui/views/passwords/manage_password_items_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_password_items_view.cc
@@ -7,6 +7,7 @@
#include <numeric>
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
#include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
@@ -267,23 +268,32 @@ void ManagePasswordItemsView::PasswordFormRow::ResetControls() {
// ManagePasswordItemsView
ManagePasswordItemsView::ManagePasswordItemsView(
ManagePasswordsBubbleModel* manage_passwords_bubble_model,
- const std::vector<const autofill::PasswordForm*>& password_forms)
+ const std::vector<autofill::PasswordForm>* password_forms)
: model_(manage_passwords_bubble_model) {
int fixed_height = PasswordFormRow::GetFixedHeight(model_->state());
- for (const autofill::PasswordForm* password_form : password_forms) {
- if (!password_form->is_public_suffix_match)
- password_forms_rows_.push_back(
- new PasswordFormRow(this, password_form, fixed_height));
+ for (const auto& password_form : *password_forms) {
+ if (!password_form.is_public_suffix_match)
+ password_forms_rows_.push_back(base::MakeUnique<PasswordFormRow>(
+ this, &password_form, fixed_height));
}
AddRows();
}
+ManagePasswordItemsView::ManagePasswordItemsView(
+ ManagePasswordsBubbleModel* manage_passwords_bubble_model,
+ const autofill::PasswordForm* password_form)
+ : model_(manage_passwords_bubble_model) {
+ password_forms_rows_.push_back(
+ base::MakeUnique<PasswordFormRow>(this, password_form, 0));
+ AddRows();
+}
+
ManagePasswordItemsView::~ManagePasswordItemsView() = default;
void ManagePasswordItemsView::AddRows() {
views::GridLayout* layout = new views::GridLayout(this);
SetLayoutManager(layout);
- for (auto* row : password_forms_rows_) {
+ for (const std::unique_ptr<PasswordFormRow>& row : password_forms_rows_) {
if (row != password_forms_rows_[0])
layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
row->AddRow(layout);

Powered by Google App Engine
This is Rietveld 408576698