Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, extensions-reviews_chromium.org, felt, tzik, tfarina, nhiroki, noyau+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Code Cleanup - Remove redundant smart-ptr get()s Given std::unique_ptr<T> t, t.get()-> is the same as t->. Similarly, *t.get() is the same as *t. Simplify extensions code to conform. Generated with clang-tidy. See https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md BUG=None Committed: https://crrev.com/165732a4b1dec1676bf479f2fed9a8df2a73316f Cr-Commit-Position: refs/heads/master@{#406117}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -506 lines) Patch
M chrome/browser/extensions/activity_log/activity_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/counting_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/counting_policy_unittest.cc View 5 chunks +45 lines, -178 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 4 chunks +41 lines, -150 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/mdns/dns_sd_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_api_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/extension_message_port.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/event_router_forwarder_unittest.cc View 11 chunks +41 lines, -56 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_action_manager_unittest.cc View 6 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_reenabler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/install_verifier.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/file_util_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Devlin
And another one for you...
4 years, 5 months ago (2016-07-15 22:12:40 UTC) #2
lazyboy
lgtm
4 years, 5 months ago (2016-07-15 22:35:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152373003/20001
4 years, 5 months ago (2016-07-18 22:16:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 22:25:27 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 22:25:51 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 22:26:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/165732a4b1dec1676bf479f2fed9a8df2a73316f
Cr-Commit-Position: refs/heads/master@{#406117}

Powered by Google App Engine
This is Rietveld 408576698