chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc ('k') | chrome/browser/extensions/event_router_forwarder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

index 8c80134a088c8174fbee5e41f59562a0c57a04ad..a660dba6927bbc39c375911b7abad8fbd2004a2e 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

@@ -100,11 +100,11 @@ class WebrtcLoggingPrivateApiTest : public ExtensionApiTest {

function, ParamsToString(parameters), browser()));

if (expect_results) {

EXPECT_TRUE(result.get());

- return result.get() != nullptr;

+ return result != nullptr;

}

EXPECT_FALSE(result.get());

- return result.get() == nullptr;

+ return result == nullptr;

}

template<typename Function>