[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

chrome/browser/extensions/extension_action_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_action_manager.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread_bundle.h"
@@ skipping 110 matching lines @@
   // replacement for missing action default_icons keys. "19" should not be
   // replaced because "38" can always be used in its place.
   scoped_refptr<Extension> extension =
       BuildExtension(DictionaryBuilder()
                          .Set("48", "icon48.png")
                          .Set("128", "icon128.png")
                          .Build(),
                      DictionaryBuilder().Build(), action_type);
 
   ASSERT_TRUE(extension.get());
-  const ExtensionAction* action = GetAction(action_type, *extension.get());
+  const ExtensionAction* action = GetAction(action_type, *extension);
   ASSERT_TRUE(action);
 
-  ASSERT_TRUE(TitlesMatch(*extension.get(), *action));
-  ASSERT_TRUE(IconsMatch(*extension.get(), 48, *action, 38));
+  ASSERT_TRUE(TitlesMatch(*extension, *action));
+  ASSERT_TRUE(IconsMatch(*extension, 48, *action, 38));
 
   // Test that the action's missing default_icons are not replaced with smaller
   // icons.
   extension =
       BuildExtension(DictionaryBuilder().Set("24", "icon24.png").Build(),
                      DictionaryBuilder().Build(), action_type);
 
   ASSERT_TRUE(extension.get());
-  action = GetAction(action_type, *extension.get());
+  action = GetAction(action_type, *extension);
   ASSERT_TRUE(action);
 
-  ASSERT_TRUE(IconsMatch(*extension.get(), 24, *action, 19));
-  ASSERT_FALSE(IconsMatch(*extension.get(), 24, *action, 38));
+  ASSERT_TRUE(IconsMatch(*extension, 24, *action, 19));
+  ASSERT_FALSE(IconsMatch(*extension, 24, *action, 38));
 
   // Test that an action's 19px icon is not replaced if a 38px action icon
   // exists.
   extension = BuildExtension(
       DictionaryBuilder().Set("128", "icon128.png").Build(),
       DictionaryBuilder()
           .Set("default_icon",
                DictionaryBuilder().Set("38", "action38.png").Build())
           .Build(),
       action_type);
 
   ASSERT_TRUE(extension.get());
-  action = GetAction(action_type, *extension.get());
+  action = GetAction(action_type, *extension);
   ASSERT_TRUE(action);
 
-  ASSERT_FALSE(IconsMatch(*extension.get(), 128, *action, 19));
+  ASSERT_FALSE(IconsMatch(*extension, 128, *action, 19));
 
   // Test that existing default_icons and default_title are not replaced.
   extension =
       BuildExtension(DictionaryBuilder().Set("128", "icon128.png").Build(),
                      DictionaryBuilder()
                          .Set("default_title", "Action!")
                          .Set("default_icon", DictionaryBuilder()
                                                   .Set("19", "action19.png")
                                                   .Set("38", "action38.png")
                                                   .Build())
                          .Build(),
                      action_type);
 
   ASSERT_TRUE(extension.get());
-  action = GetAction(action_type, *extension.get());
+  action = GetAction(action_type, *extension);
   ASSERT_TRUE(action);
 
-  ASSERT_FALSE(TitlesMatch(*extension.get(), *action));
-  ASSERT_FALSE(IconsMatch(*extension.get(), 128, *action, 19));
-  ASSERT_FALSE(IconsMatch(*extension.get(), 128, *action, 38));
+  ASSERT_FALSE(TitlesMatch(*extension, *action));
+  ASSERT_FALSE(IconsMatch(*extension, 128, *action, 19));
+  ASSERT_FALSE(IconsMatch(*extension, 128, *action, 38));
 }
 
 namespace {
 
 TEST_F(ExtensionActionManagerTest, PopulateBrowserAction) {
   TestPopulateMissingValues(kBrowserAction);
 }
 
 TEST_F(ExtensionActionManagerTest, PopulatePageAction) {
   TestPopulateMissingValues(kPageAction);
 }
 
 TEST_F(ExtensionActionManagerTest, GetBestFitActionTest) {
   // Create an extension with page action defaults.
   scoped_refptr<Extension> extension = BuildExtension(
       DictionaryBuilder().Set("48", "icon48.png").Build(),
       DictionaryBuilder()
           .Set("default_title", "Action!")
           .Set("default_icon",
                DictionaryBuilder().Set("38", "action38.png").Build())
           .Build(),
       kPageAction);
   ASSERT_TRUE(extension.get());
 
   // Get a "best fit" browser action for |extension|.
   std::unique_ptr<ExtensionAction> action =
-      manager()->GetBestFitAction(*extension.get(), ActionInfo::TYPE_BROWSER);
+      manager()->GetBestFitAction(*extension, ActionInfo::TYPE_BROWSER);
   ASSERT_TRUE(action.get());
   ASSERT_EQ(action->action_type(), ActionInfo::TYPE_BROWSER);
 
   // |action|'s title and default icon should match |extension|'s page action's.
   ASSERT_EQ(action->GetTitle(ExtensionAction::kDefaultTabId), "Action!");
   ASSERT_EQ(action->default_icon()->Get(38, ExtensionIconSet::MATCH_EXACTLY),
             "action38.png");
 
   // Create a new extension without page action defaults.
   extension =
       BuildExtension(DictionaryBuilder().Set("48", "icon48.png").Build(),
                      DictionaryBuilder().Build(), kPageAction);
   ASSERT_TRUE(extension.get());
 
-  action =
-      manager()->GetBestFitAction(*extension.get(), ActionInfo::TYPE_BROWSER);
+  action = manager()->GetBestFitAction(*extension, ActionInfo::TYPE_BROWSER);
 
   // Now these values match because |extension| does not have page action
   // defaults.
-  ASSERT_TRUE(TitlesMatch(*extension.get(), *action));
-  ASSERT_TRUE(IconsMatch(*extension.get(), 48, *action, 38));
+  ASSERT_TRUE(TitlesMatch(*extension, *action));
+  ASSERT_TRUE(IconsMatch(*extension, 48, *action, 38));
 }
 
 }  // namespace
 }  // namespace extensions